damccorm commented on code in PR #41143:
URL: https://github.com/apache/beam/pull/41143#discussion_r4525563940
##########
.test-infra/metrics/src/test/groovy/ProberTests.groovy:
##########
@@ -119,10 +122,20 @@ class ProberTests {
assert syncedSourceCount == 2 :
"One or more metrics sources have no synchronization timestamp"
+ assert minStalenessMinutes != null
assert maxStalenessMinutes != null
- assert maxStalenessMinutes <= 480 :
- "Input data is stale: ${maxStalenessMinutes} minutes\n" +
+ // gh_sync_metadata.timestamp stores the updatedAt timestamp of the most
+ // recently updated GitHub Issue (gh_issue_sync) and PR (gh_pr_sync), both
+ // updated in the same sync loop. Verify that at least one source has seen
+ // synced activity within 8 hours (480m) and both within 48 hours (2880m)
to
+ // avoid false positives during quiet overnight/weekend issue windows.
+ assert minStalenessMinutes <= 480 :
+ "Input data is stale (min staleness): ${minStalenessMinutes} minutes\n" +
+ "See: ${grafanaEndpoint}/d/data-freshness"
+
+ assert maxStalenessMinutes <= 2880 :
+ "Input data is stale (max staleness): ${maxStalenessMinutes} minutes\n" +
Review Comment:
This text is not descriptive enough. Instead of referring to min and max
staleness, this should give a descriptive error describing the meaning of
staleness. Also, to avoid false positives, lets just avoid running this over
the weekend or early on Monday when there may not have been recent activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
