damccorm commented on code in PR #41160:
URL: https://github.com/apache/beam/pull/41160#discussion_r4529175523
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1021,17 +1021,18 @@ def _invoke_process_per_window(
'instead, got \'%s\'.') % (windowed_value.value, ))
for i, p in self.placeholders_for_process:
- if core.DoFn.ElementParam == p:
+ if p is core.DoFn.ElementParam or core.DoFn.ElementParam == p:
Review Comment:
Great catch! Fixed in 30db21e534c: canonicalized `_DoFnParam` placeholders
to their `core.DoFn.<Param>` singletons in `_get_arg_placeholders` so
`_invoke_process_per_window` and `_invoke_process_batch_per_window` can use
pure `p is core.DoFn.<Param>` identity checks without falling back to `==` on
preceding `elif` branches or unpickled `DoFn`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
