tvalentyn commented on code in PR #41159:
URL: https://github.com/apache/beam/pull/41159#discussion_r4531665926
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1000,10 +1005,11 @@ def _invoke_process_per_window(
else:
window = GlobalWindow()
side_inputs = [si[window] for si in self.side_inputs]
- side_inputs.extend(additional_args)
+ if additional_args:
+ side_inputs.extend(additional_args)
args_for_process, kwargs_for_process = util.insert_values_in_args(
self.args_for_process, self.kwargs_for_process, side_inputs)
- if not self.recalculate_window_args:
+ if not self.recalculate_window_args and not additional_args:
Review Comment:
should this be a comment be in the code? or perhaps an aptly named helper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
