harshilv17 commented on issue #18458: URL: https://github.com/apache/beam/issues/18458#issuecomment-6793826556
Plan, to check the direction before I start: - `FixedWindowsTest`, `SlidingWindowsTest`, `CalendarWindowsTest`: replace the `runWindowFn` + expected-map assertions with per-timestamp assertions on `assignedWindows`, so each test states which windows a timestamp lands in. - `SessionsTest`: merging is the behavior under test there, so I'd keep a small merge helper local to that test, with expectations written as "these timestamps merge into this window". - `WindowFnTestUtils.runWindowFn` / `runWindowFnWithValue` are public in `beam-sdks-java-core`, so I'd mark them `@Deprecated` (pointing at `assignedWindows`) rather than delete them, and remove them in a later release. Does that match what you'd want, or should the methods be removed outright? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
