mxtymoshyk commented on code in PR #40850: URL: https://github.com/apache/beam/pull/40850#discussion_r4548889073
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkProgressUpdater.java: ########## Review Comment: `@NotThreadSafe` was already inaccurate before this PR, because two threads use this class. Adding `abortLock` made that obvious, so I removed it. The class Javadoc now names the two threads. The thread running the work item starts and stops reporting and calls `setWorker`. The reporting thread sends updates and receives aborts. The lock only guards handing an abort that arrives during setup over to `setWorker`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
