lukecwik commented on pull request #13026: URL: https://github.com/apache/beam/pull/13026#issuecomment-707223491
> I have a branch in progress to run the `io/kafka` tests with more kafka-client versions in [master...methodmissing:kafkaio-test-more-versions](https://github.com/apache/beam/compare/master...methodmissing:kafkaio-test-more-versions) but haven't had a window to converge on that, but can prioritise otherwise. > > Related, but forcing a newer kafka-clients version, I think that'll mostly invalidate `ConsumerSpEL` and `ProducerSpEL` as well. > > @lukecwik thoughts on the implications of bumping default kafka-clients up from 1.0.0 to 2.4.1 in 1 fell swoop? It's runtime pluggable, at Shopify we already use 2.4.1 for a long time and moving towards 2.6.0 for Beam but I worry about backwards compatibility. Also admittedly biased because #12794 would have been way less complex to implement and users of `1.0.0` in the wild is setting themselves up for other problems moving forward too 🤷♂️ 😄 > > cc @sap1ens @vvuibert The purpose of supporting multiple versions is to have greater flexibility for users so the change in #12794 would have been equally complex I believe. Typically I would lean to allowing this because we typically do perform dependency updates regularly but we have had issues in the past with some libraries like Avro and since we were already doing something special here likely means that it is important to the user community. Its best to ask on [email protected] for feedback on this change (@aromanenko-dev and @iemejia should know more about this). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
