lostluck commented on a change in pull request #13072:
URL: https://github.com/apache/beam/pull/13072#discussion_r503452026
##########
File path: sdks/go/gogradle.lock
##########
@@ -5,7 +5,7 @@ dependencies:
build:
- vcs: "git"
name: "cloud.google.com/go"
- commit: "4f6c921ec566a33844f4e7879b31cd8575a6982d"
+ commit: "03869a08dc16b35ad4968e92d34c5a2a2961b205"
Review comment:
It's a pain in the butt to update/add new dependencies to the Go SDK, so
it hasn't been kept up. This will change after we're on Go Modules for
dependency versioning, which will happen after Schemas are finished
implementation in the SDK. (I'm working on it). That would also allow users to
use the same deps as the project uses for testing. Right now, this list is
functionally for Jenkin's Use Only.
While your proposal to split the changes is generally a good policy, I
disagree that it's necessary to split the changes in this instance. There's not
nearly as much surface area vs the Python and Java SDKs, and there are no real
runners implemented in Go. If the PostCommit test passes, there's little else
we do that would detect issues with GRPC or similar.
Also, internal testing at Google is likely using much more up to date
versions of all these packages so this just brings things closer to that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
