damccorm commented on code in PR #41204:
URL: https://github.com/apache/beam/pull/41204#discussion_r4559768668
##########
sdks/python/apache_beam/io/external/xlang_kinesisio_it_test.py:
##########
@@ -273,19 +273,19 @@ def __init__(self, access_key, secret_key, region,
service_endpoint):
def create_stream(self, stream_name):
# localstack could not have initialized in the container yet so repeat
- retries = 10
+ retries = 15
Review Comment:
Why do we need to increase the number of retries?
##########
sdks/python/apache_beam/io/external/xlang_kinesisio_it_test.py:
##########
@@ -273,19 +273,19 @@ def __init__(self, access_key, secret_key, region,
service_endpoint):
def create_stream(self, stream_name):
# localstack could not have initialized in the container yet so repeat
- retries = 10
+ retries = 15
for i in range(retries):
try:
self.kinesis_client.create_stream(
StreamName=stream_name,
ShardCount=1,
)
- time.sleep(2)
break
except Exception as e:
if i == retries - 1:
logging.error('Could not create kinesis stream')
raise e
+ time.sleep(2)
Review Comment:
How does sleeping here help us? Add a comment explaining. Also, if we need
to sleep longer to support fewer retries, that is ok.
##########
sdks/python/apache_beam/yaml/integration_tests.py:
##########
@@ -1006,16 +1006,16 @@ def temp_iceberg_table_with_pk(table_data):
def _create_kinesis_stream(kinesis_client, stream_name):
Review Comment:
Same comments apply here as in the other file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
