vishalmore90 commented on PR #41049:
URL: https://github.com/apache/beam/pull/41049#issuecomment-6846967558
Hi @chamikaramj,
Thank you for reviewing my PR and for pointing this out! As a student
contributor, I really appreciate the detailed guidance on how Beam YAML derives
schema nullability from `Optional[...]` type annotations.
- Updated `PyJsYamlCombine.__init__` to annotate `group_by:
Optional[Iterable[str]] = ()` and `combine: Mapping[str, Mapping[str, Any]] =
{}`.
- Updated `_SqlCombineTransform` to annotate `group_by:
Optional[Iterable[str]] = ()` and `combine: Mapping[str, Any] = {}`.
- Disabled the `dangerous-default-value` pylint warning for both signatures.
- Verified that `generate_yaml_docs.py` now marks `group_by` as `(Optional)`
and keeps `combine` required.
- Verified all unit tests in `yaml_combine_test.py` pass cleanly.
Could you please take another look when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]