damccorm opened a new pull request, #41280:
URL: https://github.com/apache/beam/pull/41280
Note: this PR was auto-generated by tooling. Before moving it out of draft,
the author has done a full review of the PR, specifically evaluating it on the
following criteria:
- The PR is an appropriate fix for the issue (e.g. we're not changing a test
to avoid a bug)
- The PR is a simple fix to the issue (e.g. we're not adding infra when we
could just modify a test)
- The PR is not covering for other problems (e.g. if we're bumping timeouts,
it is not because we're covering for a performance problem)
Full details of the methodology of generation and review can be found here -
https://docs.google.com/document/d/14lj7ECVov4T4EdwmIzNlWrRGE3lLDMOwX5xUMGzaLoc/edit?usp=sharing
If you have concerns with the PR or with the underlying methodology used to
generate this, please comment below - they will be addressed by the author not
the tooling :)
## Summary
- Increases the JUnit `@Rule Timeout` in `DeltaLakeToIcebergCdcIT` from a
hardcoded 10 minutes (`10 * 60`) to
`Timeout.seconds(OPTIONS.getRunner().equals(DirectRunner.class) ? 300 : 20 *
60)`, matching the runner-dependent timeout used in `IcebergCatalogBaseIT` and
`IcebergCdcWriteBaseIT`.
## Root Cause
In the `IcebergIO Integration Tests on Dataflow` workflow ([run
43366381845](https://github.com/apache/beam/actions/runs/43366381845/job/131691653255)),
`DeltaLakeToIcebergCdcIT >
changeFeedAppliesToIcebergTableWithChangeTypeColumn` failed with
`org.junit.runners.model.TestTimedOutException: test timed out after 600
seconds` at
`DeltaLakeToIcebergCdcIT.applyChangeFeed(DeltaLakeToIcebergCdcIT.java:340)`
after the Dataflow Runner v2 job had already completed all operations
(`Finished operation ... at 05:45:51.531Z`) and was in `Cleaning up. Stopping
worker pool...` at 9m51s.
Commit `ea3c5dfb210` (#40230) added both `IcebergCdcWriteBaseIT` (configured
with `Timeout.seconds(OPTIONS.getRunner().equals(DirectRunner.class) ? 300 : 20
* 60)`, matching `IcebergCatalogBaseIT`) and `DeltaLakeToIcebergCdcIT`
(configured with a fixed 10-minute timeout), which leaves insufficient headroom
for Dataflow Runner v2 worker startup and job teardown in
`:sdks:java:io:iceberg:dataflowIntegrationTest`.
## Verification
- Verified locally with `./gradlew :sdks:java:io:iceberg:spotlessCheck
:sdks:java:io:iceberg:compileTestJava :sdks:java:io:iceberg:checkstyleTest`.
### Verification
- Triggered `IO_Iceberg_Integration_Tests_Dataflow.yml` workflow run on
branch: [`43379167610`](https://github.com/apache/beam/actions/runs/43379167610)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
