damccorm commented on code in PR #41060:
URL: https://github.com/apache/beam/pull/41060#discussion_r4564344886
##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -1562,9 +1570,15 @@ def insert_rows(
str(self.unique_row_id) if not insert_ids else insert_ids[i]
for i, _ in enumerate(rows)
]
+ _json_safe = (str, bool, type(None))
rows = [
- fast_json_loads(fast_json_dumps(r, default=default_encoder))
- for r in rows
+ r if (
Review Comment:
Sounds good! Removed the `BigQueryWrapper.insert_rows` fast path in
1dc1c9d892f so only the `AvroRowWriter.tell()` and `_split_table_spec()`
optimizations remain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
