damccorm commented on code in PR #41281:
URL: https://github.com/apache/beam/pull/41281#discussion_r4564615418
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyTest.java:
##########
@@ -249,7 +250,7 @@ public void
testAfterProcessingTimeContinuationTriggerEarly() throws Exception {
})
public void testAfterProcessingTimeContinuationTriggerUsingState() throws
Exception {
final long triggerMillis = 1;
- final long waitMillis = 500;
+ final long waitMillis = 2000;
Review Comment:
Good call — running it with `@BeamParallelJunit4Runner.SerialTest` alone is
sufficient so it doesn't contend with `testLargeKeys10KB`/`100KB`/`1MB`/`10MB`
in `GroupByKeyTest.BasicTests` inside the same JVM, and keeping `waitMillis =
500` avoids adding 1.5s of wall-clock sleep across every `ValidatesRunner`
suite.
I have applied and verified that change locally (`waitMillis = 500` with
only `@BeamParallelJunit4Runner.SerialTest`, 12/12 passing in
`:runners:direct-java:validatesRunner --tests
"org.apache.beam.sdk.transforms.GroupByKeyTest\$BasicTests"`) — let me know if
you'd like me to push that commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
