jk-shah opened a new issue, #41346:
URL: https://github.com/apache/beam/issues/41346
### What happened?
`BigTableEnrichmentHandler.__call__`
(`sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py`, lines
`118-148`) has two bugs when extracting `row_key`:
1. **Nullable `None` join keys are queried as literal `b'None'` (lines
`123-126`)**:
```python
request_dict = request._asdict()
row_key_str = str(request_dict[self._row_key])
row_key = row_key_str.encode(self._encoding)
row = self._table.read_row(row_key, filter_=self._row_filter)
```
When an input `beam.Row` has `None` for `self._row_key`, `str(None)`
silently coerces it to `'None'`, issuing a live Bigtable `read_row(b'None')`
RPC (and joining unrelated data if a `'None'` row exists).
2. **Blank field name in `KeyError` message when `row_key` column is missing
(lines `118, 124, 146-147`)**:
`row_key_str` is initialized to `""` on line `118`. When `self._row_key`
is absent from `request_dict`, `request_dict[self._row_key]` on line `124`
raises `KeyError` *before* `row_key_str` is assigned, so lines `146-147` raise:
`KeyError: 'row_key not found in input PCollection.'` (printing an empty
string instead of `self._row_key`).
Minimal reproducer:
```python
from unittest import mock
import apache_beam as beam
from apache_beam.transforms.enrichment_handlers.bigtable import
BigTableEnrichmentHandler
h = BigTableEnrichmentHandler(
project_id='p', instance_id='i', table_id='t', row_key='user_id')
h._table = mock.MagicMock()
h._table.read_row.return_value = None
h(beam.Row(user_id=None))
print('Queried Bigtable key:', h._table.read_row.call_args[0][0]) # b'None'
try:
h(beam.Row(other_col='x'))
except KeyError as e:
print('KeyError:', e) # "KeyError: 'row_key not found in input
PCollection.'"
```
### Cause
`request_dict[self._row_key]` is passed unconditionally to `str(...)`
without checking `is None`, and `except KeyError:` interpolates `row_key_str`
(`""`) instead of `self._row_key`.
### Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
### Issue Components
- [x] Component: Python SDK
- [ ] Component: Java SDK
- [ ] Component: Go SDK
- [ ] Component: Typescript SDK
- [x] Component: IO connector
- [ ] Component: Beam YAML
- [ ] Component: Beam ML
- [ ] Component: Beam examples
- [ ] Component: Beam playground
- [ ] Component: Beam katas
- [ ] Component: Website
- [ ] Component: Infrastructure
- [ ] Component: Spark Runner
- [ ] Component: Flink Runner
- [ ] Component: Prism Runner
- [ ] Component: Hazelcast Jet Runner
- [ ] Component: Google Cloud Dataflow Runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]