codewarnab commented on PR #41289:
URL: https://github.com/apache/beam/pull/41289#issuecomment-6890193985

   Thanks @vishalmore90, sounds good — please go ahead. For (4), I’d suggest 
rendering bools as TRUE/FALSE, quoting strings as SQL literals, and raising a 
ValueError for any other non-numeric type, so the behavior is explicit. Happy 
to re-review once the follow-up commit is up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to