dhanusharer commented on PR #40768: URL: https://github.com/apache/beam/pull/40768#issuecomment-6938785934
Hi @claudevdm, Following your review and recommended rollout strategy, this PR is scoped to **Phase 1**: - **Preserved `setup.py` Cap**: Kept `setup.py` at `pandas>=2.2.2,<2.4` so existing user environments and default containers remain completely unaffected (zero blast radius). - **Hardening & Defensive Reflection**: Retained backward-compatible `hasattr()` guards in `frames.py` and defensive reflection in `frame_base.py`. - **Type Compatibility**: Updated `dtype_to_fieldtype` in `pandas_type_compatibility.py` to ensure byte string dtypes (`kind == 'S'`) are preserved as `bytes` rather than misclassified as string types, and added unit tests in `pandas_type_compatibility_test.py`. - **Proactive Pandas 3 Testing on 2.3**: Added the `py311-pandas-23future` environment in `tox.ini` and `build.gradle` running with `PANDAS_MODE__COPY_ON_WRITE=1` and `PANDAS_FUTURE__INFER_STRING=1`. - **Clean CI & Merge**: Rebased / merged with the latest `upstream/master` (0 merge conflicts, formatted with Beam's `yapf` configuration). Could a committer please approve the workflow runs, and could you take another look when you get a chance? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
