jonathansudhakar1 commented on issue #21531: URL: https://github.com/apache/beam/issues/21531#issuecomment-6955072227
@stankiewicz, a polite follow-up, since you've worked on `SpannerAccessor` recently (#39149): would you have a view on the approach in [my comment above](https://github.com/apache/beam/issues/21531#issuecomment-6773835203)? It still applies on current master (2e901557a57): `createSpannerOptions` always calls `setHost(...)` ([L262](https://github.com/apache/beam/blob/2e901557a57/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java#L262)), which clears the emulator host the client read from `SPANNER_EMULATOR_HOST`. The question is whether you'd welcome a fix that falls back to `SPANNER_EMULATOR_HOST` only when neither `withEmulatorHost` nor a non-default or experimental host is set, or whether you'd rather keep requiring `withEmulatorHost` and just document that the variable is ignored. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
