prodriguezdefino commented on PR #41075:
URL: https://github.com/apache/beam/pull/41075#issuecomment-6961227209
Thank you for the review @jrmccluskey . I will split this PR into smaller
parts so each diff is easy to check:
- Prep and small fixes: Extract `initAggStateLocked`, skip `LinkID{}` in
`StateForBundle`, and fix `Bundles()`. Also fix `computeNextTriggeredPane` and
`buildProcessingTimeBundle`, and add `OnWatermarkFire` in strategy.go.
- Core accumulating hold fix: Move emitted accumulating elements into
`StateData.Accumulated` and track owed `ON_TIME` panes in `pendingOnTime`.
- `ClosingBehavior_EMIT_ALWAYS` support: Track closing panes in
`pendingClosing` in a follow-up PR.
Note on `injectTriggeredBundlesIfReady()`: only `initAggStateLocked` came
from that function. The other new helpers near it manage `pendingOnTime` and
`pendingClosing` holds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]