prodriguezdefino opened a new pull request, #41443:
URL: https://github.com/apache/beam/pull/41443
This PR splits out the prep changes and standalone trigger fixes from
#41075. A follow-up PR will move emitted accumulating elements out of
`dnt.elements`.
Changes
- Trigger watermark updates (strategy.go, strategy_test.go)
- Add `WinStrat.OnWatermarkFire` and `Trigger.onWatermarkFire` across all
trigger types.
- Use comma-ok type assertions on `ts.extra.(bool)` in
`TriggerAfterEndOfWindow` and `TriggerDefault`.
- Add unit tests in `TestOnWatermarkFire`.
- Aggregation helpers and standalone fixes (elementmanager.go)
- Extract `initAggStateLocked from `injectTriggeredBundlesIfReady`.
- Skip `LinkID{}` in `StateForBundle` so it does not copy internal
aggregation state or let `PersistBundle` overwrite it.
- Apply non-zero `pendingAdjustment` values in `ElementManager.Bundles`
before checking if ok.
- Set `NonSpeculativeIndex = 0` on the first late firing in
`computeNextTriggeredPane`.
- Pass `isLateForOutput` to `computeNextWatermarkPane` so firings past
`ss.output` get `PaneLate`.
- Mark panes `IsLast` when the root trigger finishes in
`injectTriggeredBundlesIfReady` and `buildProcessingTimeBundle`.
- Populate `bundlePane` fields instead of an empty struct in
`buildProcessingTimeBundle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]