alisha-1000 commented on issue #24662: URL: https://github.com/apache/beam/issues/24662#issuecomment-6981312873
@je-ik I looked into this on current master and couldn't reproduce it. - `BufferingDoFnRunner.onTimer()` now adds the timer's output timestamp to the buffer's watermark hold. - When the timer fires, `onEventTime` starts a bundle, and `maybeEmitWatermark` doesn't emit a watermark while that bundle is open. - When the watermark is emitted later, `getEffectiveInputWatermark()` already applies `bufferingDoFnRunner.getOutputWatermarkHold()`, so the buffered timer holds the output watermark. In a `DoFnOperator` test with a keyed `@RequiresStableInput` DoFn that sets a timer at 50, the output after watermark 100 and the checkpoint is `[Watermark 50, timer output @50, Watermark 100]`, so the timer output isn't late. `ExecutableStageDoFnOperator` extends `DoFnOperator` and uses the same watermark logic, but I haven't tested the portable path directly. I opened #41448 to add this as a regression test. Unless you know of another path where this can still happen, would you be OK closing this issue once the PR is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
