shikhabhadoria opened a new pull request, #41453:
URL: https://github.com/apache/beam/pull/41453

   Addresses #41356. This is 3 of 3 stacked PRs that replace #41423.
   
   Depends on #41451 and #41452. Merge in that order: join semantics, then the 
file handler, then this YAML surface. This branch contains the earlier commits; 
the commit to review here is `[Python/YAML] Route Enrichment misses and RPC 
failures to error_handling`.
   
   ## Summary
   - Registers `enrichment_handler: File` (`FileEnrichmentHandler`) in Beam 
YAML. The import is separate from the optional GCP handlers, so the file 
handler loads without `apache-beam[gcp]`.
   - Passes `on_miss` and `prefix` through `enrichment_transform`.
   - Decorates the YAML transform with 
`maybe_with_exception_handling_transform_fn`, so `error_handling` receives both 
RPC failures and `on_miss: dlq` misses.
   - Documents `File`, `on_miss`, and `prefix` on `enrichment_transform` for 
the generated YAML docs.
   
   ## Test plan
   - [x] `pytest apache_beam/yaml/yaml_enrichment_test.py 
apache_beam/transforms/enrichment_handlers/file_test.py 
apache_beam/transforms/enrichment_test.py 
apache_beam/io/requestresponse_test.py` — 30 passed
   - [x] Existing enrichment-handler unit tests (`bigquery`, `bigtable`, 
`cloudsql`, `feast`, `vertex_ai_feature_store`) — 5 skipped on missing optional 
dependencies, 0 failed
   - [x] `ruff check` on the changed Python files
   - [x] `git diff --check` (no whitespace errors)
   - [ ] Python precommit
   
   ## Checklist
   - [x] If this contribution is large, please file an Apache Individual 
Contributor License Agreement.
   - [x] Mention the appropriate issue in the description (`addresses #41356`).
   - [x] Update `CHANGES.md` with noteworthy changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to