JunaidAhamed-7777 commented on issue #40994:
URL: https://github.com/apache/beam/issues/40994#issuecomment-6988926474

   One compatibility case worth keeping in the tests: 
[AvroUtilsTest](https://github.com/apache/beam/blob/5341c0facbbc04a21b7239186cab389796b66dce/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtilsTest.java#L192-L207)
 expects generic `time-millis` and `time-micros` fields to come back as raw 
int/long values. I'd keep that behavior when no Beam TIME schema is requested 
and test the `LocalTime` conversion separately when it is.
   
   A small Java `LocalTime` check kept `12:34:56.123456` at microsecond 
precision, while milliseconds gave `12:34:56.123`. Microseconds still truncated 
`23:59:59.999999999` to `23:59:59.999999`. I haven't run the Beam or Parquet 
suite for this. A round-trip test for the chosen precision, plus null and 
midnight, would make the expected behavior clear without changing the generic 
Avro cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to