Abacn commented on code in PR #41462:
URL: https://github.com/apache/beam/pull/41462#discussion_r4621325213
##########
runners/google-cloud-dataflow-java/build.gradle:
##########
@@ -247,15 +247,13 @@ def commonRunnerV2ExcludeCategories = [
]
// ValidatesRunner parallelism. Each test worker JVM runs ValidatesRunner
tests on several threads;
-// where TestDataflowRunner can merge tests into one Dataflow job
(-PtestBatching) many more
-// threads are useful since most of them just contribute a member to the next
merged job rather
-// than a job of their own. Tests that cannot be merged are still one job
each, so where merging is
-// off the thread count is kept low to bound the number of concurrent jobs per
worker JVM.
-//
-// Merging of streaming tests is opt-in (-PstreamingTestBatching=true) while
it is being validated;
-// without it every test of a streaming task is a job of its own.
+// where TestDataflowRunner can merge tests into one Dataflow job
(-PtestBatching,
+// -PstreamingTestBatching) many more threads are useful since most of them
just contribute a
+// member to the next merged job rather than a job of their own. Tests that
cannot be merged are
+// still one job each, so where merging is off the thread count is kept low to
bound the number of
+// concurrent jobs per worker JVM.
def validatesRunnerTestBatching = project.findProperty('testBatching') ?:
'true'
-def validatesRunnerStreamingTestBatching =
project.findProperty('streamingTestBatching') ?: 'false'
+def validatesRunnerStreamingTestBatching =
project.findProperty('streamingTestBatching') ?: 'true'
Review Comment:
We can just retire this flag for now? Both batch and streaming tests can use
single flag testBatching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]