tejasiyer-dev commented on code in PR #40543:
URL: https://github.com/apache/beam/pull/40543#discussion_r4624248689


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java:
##########
@@ -1195,6 +1208,9 @@ public WriteFilesResult<DestinationT> 
expand(PCollection<UserT> input) {
       if (getBatchMaxBufferingDuration() != null) {
         write = 
write.withBatchMaxBufferingDuration(getBatchMaxBufferingDuration());
       }
+      if (getDirectWriteByteThreshold() != null) {

Review Comment:
   I think if we had it default on, pipelines with withNumShards(N) would have 
their shard counts changed without opting in. 
   
   And also, turning it on by default changes the WriteFiles step graph, 
breaking --update for existing streaming jobs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to