jk-shah commented on code in PR #41383:
URL: https://github.com/apache/beam/pull/41383#discussion_r4624826751


##########
sdks/python/apache_beam/yaml/yaml_combine.py:
##########
@@ -128,9 +129,11 @@ def create_combine_fn(fn_spec):
             fn_spec['type'])
         if 'config' in fn_spec:
           fn = fn(**fn_spec['config'])
+        elif isinstance(fn, type) and issubclass(fn, beam.CombineFn):

Review Comment:
   Thanks for catching this! Added an inline comment explaining why zero-arg 
CombineFn classes returned by load_from_source are instantiated when config is 
omitted, and updated the PR description accordingly.
   
   Also ran an end-to-end Beam YAML Combine -> WriteToParquet pipeline on Cloud 
Dataflow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to