je-ik commented on code in PR #41448:
URL: https://github.com/apache/beam/pull/41448#discussion_r4628028584


##########
runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperatorTest.java:
##########
@@ -2324,6 +2325,138 @@ public void processElement(ProcessContext context) {
     testHarness.close();
   }
 
+  /**
+   * Ensures that the output watermark does not pass the output timestamp of 
an event-time timer
+   * which has fired but is still buffered because of {@code 
@RequiresStableInput}.
+   */
+  @Test
+  public void testExactlyOnceBufferingOutputWatermarkHoldsForBufferedTimers() 
throws Exception {
+    FlinkPipelineOptions options = FlinkPipelineOptions.defaults();
+    options.setStreaming(true);
+    options.setMaxBundleSize(1L);
+    options.setCheckpointingInterval(1L);

Review Comment:
   This as well, if we increase to to something about 100-200 ms?



##########
runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperatorTest.java:
##########
@@ -2324,6 +2325,138 @@ public void processElement(ProcessContext context) {
     testHarness.close();
   }
 
+  /**
+   * Ensures that the output watermark does not pass the output timestamp of 
an event-time timer
+   * which has fired but is still buffered because of {@code 
@RequiresStableInput}.
+   */
+  @Test
+  public void testExactlyOnceBufferingOutputWatermarkHoldsForBufferedTimers() 
throws Exception {
+    FlinkPipelineOptions options = FlinkPipelineOptions.defaults();
+    options.setStreaming(true);
+    options.setMaxBundleSize(1L);

Review Comment:
   I'm thinking if large bundles and mixing timers with actual data in the test 
might better exercise the code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to