stankiewicz opened a new pull request, #41473:
URL: https://github.com/apache/beam/pull/41473

   SpannerOptions.Builder reads SPANNER_EMULATOR_HOST from the environment, but 
SpannerAccessor unconditionally calls setHost() with the default batch Spanner 
endpoint, which clears the emulator host on the builder unless 
withEmulatorHost() was set explicitly.
   
   Fall back to SPANNER_EMULATOR_HOST when neither an explicit emulator host, 
experimental host, nor non-default host is configured, and apply the same 
NoCredentials and local channel provider handling as an explicit emulator host.
   
   Fixes https://github.com/apache/beam/issues/21531
   
   <!--
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    - [ ] Replace these instructions with a description of your change and why 
you have made it.
    - [ ] Mention the appropriate issue in your description (for example: 
`addresses #123` or `fixes #456`).
    - [ ] Update `CHANGES.md` with noteworthy changes.
   
   See [CONTRIBUTING.md]() for more details.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] [SpannerIO] Respect SPANN... stankiewicz (via GitHub) via github

Reply via email to