jayyyyqwq opened a new pull request, #41475: URL: https://github.com/apache/beam/pull/41475
Fixes #21262. `AfterAny` and `AfterAll` can fire without finishing when their children keep running. In `AfterEach(AfterAny(Always(), Always()), AfterCount(2))`, three elements arriving separately produce three panes, `[a]`, `[b]`, and `[c]`. The expected panes are `[a]` and `[b, c]`. Replacing `AfterAny` with `AfterAll` gives the same result. I made both triggers finish after their first firing and updated their data-loss classification to match. The parallel trigger keeps `OrFinally`’s existing completion behavior. I also release the watermark hold on a final pane. The existing DirectRunner stall test exposed that hold when a trigger finished before the end of the window. Both pane-sequence cases failed before the fix and passed after it. The full Python trigger test file passed with 106 tests, 18 skips, and 2 passing subtests. I also checked that `OrFinally` can still emit a pane before its final trigger fires. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
