github-actions[bot] commented on code in PR #41479:
URL: https://github.com/apache/beam/pull/41479#discussion_r4632296751
##########
sdks/python/container/ml/py311/base_image_requirements.txt:
##########
@@ -223,7 +223,7 @@ threadpoolctl==3.8.0
tokenizers==0.21.4
torch==2.8.0+cpu
tqdm==4.70.1
-transformers==4.55.4
+transformers==5.10.1
Review Comment:
**🔴 Critical**: Bumping `transformers` to `5.10.1` in isolation breaks the
container image dependency check (`pip check`) and conflicts with
`sdks/python/setup.py`:
1. **Unmet / conflicting pinned dependencies in this file**:
- `transformers==5.10.1` requires `huggingface-hub>=1.5.0,<2.0`, but line
87 pins `huggingface_hub==0.36.2`.
- `transformers==5.10.1` requires `tokenizers>=0.22.0,<=0.23.0`, but line
224 pins `tokenizers==0.21.4`.
- `transformers==5.10.1` requires `typer`, which is missing from this
lockfile.
2. **Conflict with `sdks/python/setup.py`**:
- Both `ml_cpu` and `ml_base_core` in `sdks/python/setup.py` currently
pin `'transformers>=4.28.0,<4.56.0'` (and `'tokenizers>=0.13.3,<0.22.0'`).
To upgrade `transformers` to 5.x, the version bounds in
`sdks/python/setup.py` must be updated first and the container requirements
regenerated via `./gradlew
:sdks:python:container:generatePythonRequirementsAll`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]