shikhabhadoria commented on PR #41451: URL: https://github.com/apache/beam/pull/41451#issuecomment-7031269204
@JunaidAhamed-7777 Good catch. Without a static handler schema, `_null_fields` was being learned from the first hit on that DoFn instance, so a miss before any hit kept only the input fields while a miss after a hit got null filled enriched columns. That made miss output order dependent across workers. I removed that learning path. For `on_miss="null"`: - If the handler provides a static schema (`get_output_schema()` or a known column list), unmatched rows still get those enriched fields set to `None`. - If it does not, unmatched rows keep only their input fields, and that is consistent whether the miss is processed before or after a hit. Added `test_on_miss_null_schemaless_miss_first_is_stable` covering miss first and hit first. `pytest` on `enrichment_test.py` and `requestresponse_test.py` is 18 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
