kennknowles commented on a change in pull request #13087:
URL: https://github.com/apache/beam/pull/13087#discussion_r504081057
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -147,21 +147,24 @@ def commonExcludeCategories = [
'org.apache.beam.sdk.testing.LargeKeys$Above10MB',
'org.apache.beam.sdk.testing.UsesAttemptedMetrics',
'org.apache.beam.sdk.testing.UsesCrossLanguageTransforms',
- 'org.apache.beam.sdk.testing.UsesDistributionMetrics',
- 'org.apache.beam.sdk.testing.UsesGaugeMetrics',
'org.apache.beam.sdk.testing.UsesSetState',
'org.apache.beam.sdk.testing.UsesMapState',
'org.apache.beam.sdk.testing.UsesOrderedListState',
'org.apache.beam.sdk.testing.UsesSplittableParDoWithWindowedSideInputs',
'org.apache.beam.sdk.testing.UsesTestStream',
'org.apache.beam.sdk.testing.UsesParDoLifecycle',
'org.apache.beam.sdk.testing.UsesMetricsPusher',
- 'org.apache.beam.sdk.testing.UsesBundleFinalizer'
+ 'org.apache.beam.sdk.testing.UsesBundleFinalizer',
]
// For the following test tasks using legacy worker, set
workerHarnessContainerImage to empty to
// make Dataflow pick up the non-versioned container image, which handles a
staged worker jar.
-def createLegacyWorkerValidatesRunnerTest = { name,
pipelineOptions=legacyPipelineOptions, disabledTests=[] ->
+def createLegacyWorkerValidatesRunnerTest = { Map args ->
Review comment:
From what I can tell, this is unfortunately the idiomatic way to do
named args in Groovy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
