tvalentyn commented on pull request #13081: URL: https://github.com/apache/beam/pull/13081#issuecomment-707880011
> Renaming `CombinerWithoutDefaults` would be backwards incompatible. Users needs to change their potentially and I think we can avoid that part of the change. Rest of the change LGTM. It's a fairly recent introduction, see: #12074, and not included in https://github.com/apache/beam/blob/c3477a8eadf3fef6c173166bb1f720ed6c8ffe42/sdks/python/apache_beam/transforms/combiners.py#L56. Do you still think renaming would be a concern? If so I can add an alias. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
