udim commented on a change in pull request #13000:
URL: https://github.com/apache/beam/pull/13000#discussion_r504140814
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2063,8 +2066,13 @@ class BeamModulePlugin implements Plugin<Project> {
args '-c', ". ${project.ext.envdir}/bin/activate && cd
${copiedPyRoot} && scripts/run_tox.sh $tox_env $distTarBall '$posargs'"
}
}
- inputs.files project.pythonSdkDeps
- outputs.files project.fileTree(dir:
"${pythonRootDir}/target/.tox/${tox_env}/log/")
+ outputs.cacheIf { true }
+ inputs.files(project.pythonSdkDeps)
+ .withPropertyName('pythonSdkDeps')
+ .withPathSensitivity(PathSensitivity.RELATIVE)
+
+ outputs.dir("${project.buildDir}/srcs/sdks/python/")
Review comment:
You're right, according to the docs:
projectDir | File | The directory containing the build script.
-- | -- | --
buildDir | File | projectDir/build
https://docs.gradle.org/current/userguide/writing_build_scripts.html
(aside: copy-pasting a table just generates the markdown? what)
So forget my comment above. However, by my understanding the new definition
of `outputs` is still going to be empty after the task is run, but the
screenshot above shows it has a copy of the repo (`pythonSdkDeps`?). What's
causing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
