TheNeuralBit commented on a change in pull request #12827:
URL: https://github.com/apache/beam/pull/12827#discussion_r504133636



##########
File path: 
website/www/site/content/en/documentation/dsls/sql/extensions/create-external-table.md
##########
@@ -313,9 +315,12 @@ Write Mode supports writing to a topic.
 
 ### Supported Payload

Review comment:
       ```suggestion
   ### Supported Payload Formats
   ```

##########
File path: 
website/www/site/content/en/documentation/dsls/sql/extensions/create-external-table.md
##########
@@ -294,14 +294,16 @@ KafkaIO is experimental in Beam SQL.
 CREATE EXTERNAL TABLE [ IF NOT EXISTS ] tableName (tableElement [, 
tableElement ]*)
 TYPE kafka
 LOCATION 'kafka://localhost:2181/brokers'
-TBLPROPERTIES '{"bootstrap.servers":"localhost:9092", "topics": ["topic1", 
"topic2"]}'
+TBLPROPERTIES '{"bootstrap.servers":"localhost:9092", "topics": ["topic1", 
"topic2"], "format": "avro"}'
 ```
 
 *   `LOCATION`: The Kafka topic URL.
 *   `TBLPROPERTIES`:
     *   `bootstrap.servers`: Optional. Allows you to specify the bootstrap
         server.
     *   `topics`: Optional. Allows you to specify specific topics.
+    *   `format`: Optional. Allows you to specify the Kafka values format. 
Possible values are
+    {`csv`, `avro`}, capitalization does not matter. Defaults to `csv`.

Review comment:
       ```suggestion
       {`csv`, `avro`}. Defaults to `csv`.
   ```

##########
File path: 
website/www/site/content/en/documentation/dsls/sql/extensions/create-external-table.md
##########
@@ -313,9 +315,12 @@ Write Mode supports writing to a topic.
 
 ### Supported Payload
 
-*   CSV
+*   CSV (default)
     *   Beam parses the messages, attempting to parse fields according to the
         types specified in the schema.
+*   Avro
+    *   Beam parses the messages, attempting to parse fields according to the
+        types specified in the schema. Avro schema is automatically deduced.

Review comment:
       ```suggestion
   *   CSV (default)
       *   Beam parses the messages, attempting to parse fields according to the
           types specified in the schema.
   *   Avro
       *   An Avro schema is automatically generated from the specified field
           types. It is used to parse incoming messages and to format outgoing
           messages.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to