kamilwu commented on pull request #13048: URL: https://github.com/apache/beam/pull/13048#issuecomment-708515000
> Are setup/teardown invoked for its use in CombineFnState? @robertwb Do you mean `CombiningValueRuntimeState`? If so, they're not. I can fix that, but I wonder where setup/teardown should be invoked. The setup could be invoked on `CombiningValueRuntimeState` initialization, but what's the best place for teardown? [CombiningValueRuntimeState.clear](https://github.com/apache/beam/blob/c921b0c8384809dbcab3edcd5007e92da25067c6/sdks/python/apache_beam/runners/worker/bundle_processor.py#L498) looks good, but only if it's called exactly once per object's lifetime. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
