youngoli commented on a change in pull request #13123:
URL: https://github.com/apache/beam/pull/13123#discussion_r505147911
##########
File path: sdks/go/pkg/beam/core/runtime/harness/harness.go
##########
@@ -158,6 +158,60 @@ func Main(ctx context.Context, loggingEndpoint,
controlEndpoint string) error {
type bundleDescriptorID string
type instructionID string
+const circleBufferCap = 1000
+
+// circleBuffer is an ordered eviction buffer
+type circleBuffer struct {
+ // a plan that's either about to start or has finished recently
Review comment:
nit: This comment doesn't make sense anymore because there's no
indication that this map is for inactive plans. Can probably adjust these
comments a bit, maybe delete this one and amend the one below to refer to "buf"
instead of "inactive map".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
