Hannah-Jiang commented on a change in pull request #13117:
URL: https://github.com/apache/beam/pull/13117#discussion_r505703292
##########
File path: sdks/java/container/license_scripts/pull_licenses_java.py
##########
@@ -140,17 +149,22 @@ def execute(dep):
}
'''
- name = dep['moduleName'].split(':')[1].lower()
+ name = dep['moduleName'].split(':')[1]
version = dep['moduleVersion']
name_version = name + '-' + version
+ # javac is not a runtime dependency
+ if name == 'javac':
+ logging.debug('Skipping', name_version)
+ return
+ # skip self dependencies
+ if name.startswith('beam'):
Review comment:
If I compare to the original code, it should be `dep['moduleName']`
instead of `name`. If a beam package is 'beam:xxx' and the `xxx` does not has
`beam` in it, it wouldn't skipped. And I also recommend applying `lower()` when
checking if startswith 'beam'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
