pabloem commented on a change in pull request #13055:
URL: https://github.com/apache/beam/pull/13055#discussion_r506654118
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -2002,6 +2007,11 @@ static String getExtractDestinationUri(String
extractDestinationDir) {
return toBuilder().setFormatFunction(formatFunction).build();
}
+ /** Formats the user's type into a {@link TableRow} to be written to an
error collector. */
+ public Write<T> withFailsafeFormatFunction(SerializableFunction<T,
TableRow> formatFunction) {
Review comment:
Just one change request:
- Perhaps can we rename this to something that doesn't assume this fail-safe
keyword is known by users? Perhaps `withFailedInsertFormatFunction`?
- And can you add some detail to the Javadoc so users will understand what
this does?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
