yifanmai commented on a change in pull request #13100:
URL: https://github.com/apache/beam/pull/13100#discussion_r506769870
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -562,9 +569,10 @@ def copy_subtransforms(transform):
copy_subtransforms(transform)
else:
transform = stage.executable_stage_transform(
- known_runner_urns, all_consumers, components)
+ known_runner_urns, all_consumers, pipeline_proto.components)
Review comment:
Yes but this is still safe to do. The only additional components in
`components` but not `pipeline_proto.components` are executable stage
transforms, and these are not used within `executable_stage_transform()` - in
fact `executable_stage_transform()` does not use the transforms in the passed
in components at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
