lukecwik commented on a change in pull request #13118:
URL: https://github.com/apache/beam/pull/13118#discussion_r509407958
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/runners/PTransformReplacements.java
##########
@@ -15,20 +15,22 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.beam.runners.core.construction;
+package org.apache.beam.sdk.runners;
import static
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument;
import java.util.Map;
import java.util.Set;
-import org.apache.beam.sdk.runners.AppliedPTransform;
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.annotations.Internal;
import org.apache.beam.sdk.transforms.PTransform;
import org.apache.beam.sdk.values.PCollection;
-import org.apache.beam.sdk.values.PValue;
import org.apache.beam.sdk.values.TupleTag;
import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables;
/** */
+@Internal
Review comment:
We agree on replaceAll like functionality not existing in sdks core but
I don't think having yet another layer on top of the protos would be much
better then a few static methods that do common things that are necessary to
easily walk and mutate a graph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
