TheNeuralBit commented on a change in pull request #13134:
URL: https://github.com/apache/beam/pull/13134#discussion_r511002716
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1646,8 +1656,10 @@ class BeamModulePlugin implements Plugin<Project> {
project.ext.applyJavaNature(
exportJavadoc: false,
enableSpotbugs: false,
- enableChecker: false,
publish: configuration.publish,
+ generatedClassPatterns: [
+ '^org\\.apache\\.beam\\..*'
+ ],
Review comment:
This looked concerning until I looked around and realized the
"portability" nature means its for making modules that generate protobuf/grpc
code. The comment above "applyPortabilityNature should only be applied to
projects that want to use vendored gRPC / protobuf dependencies" isn't very
helpful. Maybe I'll send you a PR to document these natures.
##########
File path: sdks/java/extensions/sql/hcatalog/build.gradle
##########
@@ -18,7 +18,12 @@
plugins { id 'org.apache.beam.module' }
-applyJavaNature(enableChecker:false,automaticModuleName:
'org.apache.beam.sdk.extensions.sql.meta.provider.hcatalog')
+applyJavaNature(
+ automaticModuleName:
'org.apache.beam.sdk.extensions.sql.meta.provider.hcatalog',
+ classesTriggerCheckerBugs: [
+ 'HCatalogTable': '',
Review comment:
not yet filed or TODO
##########
File path: sdks/java/extensions/protobuf/build.gradle
##########
@@ -18,8 +18,13 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
- enableChecker: false,
ignoreRawtypeErrors: true,
+ generatedClassPatterns: [
+
'^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto2CoderTestMessages',
+
'^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto2SchemaMessages',
+
'^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto3SchemaMessages',
+ '^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto3SchemaOptions',
Review comment:
Is it possible to use [slashy
strings](https://groovy-lang.org/syntax.html#_slashy_string) in our gradle
files? That'd clean these arrays up a bit.
##########
File path: sdks/java/io/kudu/build.gradle
##########
@@ -18,8 +18,12 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
- enableChecker: false,
+
ignoreRawtypeErrors:true,
+ classesTriggerCheckerBugs: [
+ 'KuduTestUtils': '',
+ 'KuduIOIT': '',
Review comment:
not yet filed or TODO
##########
File path: sdks/java/io/hadoop-format/build.gradle
##########
@@ -20,7 +20,7 @@ import groovy.json.JsonOutput
plugins { id 'org.apache.beam.module' }
applyJavaNature(
- enableChecker:false,
+
Review comment:
nit: some of these are left with unnecessary whitespace (not a big deal
if its a pain to fix)
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -726,11 +729,15 @@ class BeamModulePlugin implements Plugin<Project> {
options.encoding = "UTF-8"
// As we want to add '-Xlint:-deprecation' we intentionally remove
'-Xlint:deprecation' from compilerArgs here,
// as intellij is adding this, see
https://youtrack.jetbrains.com/issue/IDEA-196615
- options.compilerArgs -= ["-Xlint:deprecation"]
+ options.compilerArgs -= [
+ "-Xlint:deprecation",
+ ]
options.compilerArgs += ([
'-parameters',
'-Xlint:all',
- '-Werror'
+ '-Werror',
+ '-Xmaxerrs',
+ '10000'
Review comment:
Is this a typo for maxerrors?
I'm assuming you added this to make it quicker to run, can/should we drop it
now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
