Hannah-Jiang commented on a change in pull request #11243: URL: https://github.com/apache/beam/pull/11243#discussion_r511191738
########## File path: sdks/java/container/license_scripts/license_script.sh ########## @@ -0,0 +1,38 @@ + # Licensed to the Apache Software Foundation (ASF) under one + # or more contributor license agreements. See the NOTICE file + # distributed with this work for additional information + # regarding copyright ownership. The ASF licenses this file + # to you under the Apache License, Version 2.0 (the + # License); you may not use this file except in compliance + # with the License. You may obtain a copy of the License at + # + # http://www.apache.org/licenses/LICENSE-2.0 + # + # Unless required by applicable law or agreed to in writing, software + # distributed under the License is distributed on an AS IS BASIS, + # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + # See the License for the specific language governing permissions and + # limitations under the License. + +set -e +# reports are generated at ~/beam/java_third_party_licenses +./gradlew generateLicenseReport --rerun-tasks + +# install packages needed for pull_licenses_java.py +pip install beautifulsoup4==4.9.0 +pip install future==0.17.1 +pip install PyYAML==5.3 +pip install tenacity==5.0.4 + +# pull licenses, notices and source code +python sdks/java/container/license_scripts/pull_licenses_java.py + +pip uninstall -y beautifulsoup4 +pip uninstall -y future +pip uninstall -y PyYAML +pip uninstall -y tenacity + +mkdir sdks/java/container/third_party_licenses +cp -r java_third_party_licenses/*.jar sdks/java/container/third_party_licenses/ +cp -r java_third_party_licenses/*.csv sdks/java/container/third_party_licenses/ +rm -rf java_third_party_licenses Review comment: Here is what happens. 1. Create `~/beam/java_third_party_licenses` folder, because the plugin generates correct dependency list only when run from root and the folder should be under root. 2. Copy the files from `~/beam/java_third_party_licenses` to `sdks/java/container/third_party_licenses/`. 3. Add the files to the containers. 4. Remove `~/beam/java_third_party_licenses` in order to remove temp files and write to a clean new folder for next run. If the problem with 1 is solved with new version of the plugin, 1 can be skipped. I think it's a good practice to remove temp files from local. But I agree it might miss leading, better to add a comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
