robinyqiu commented on a change in pull request #12643:
URL: https://github.com/apache/beam/pull/12643#discussion_r512460592
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java
##########
@@ -87,16 +87,17 @@
.put("$extract_time", "TIME")
.put("$extract_datetime", "DATETIME")
.build();
- public static final String DOUBLE_POSITIVE_INF_FUNCTION =
"double_positive_inf";
- public static final String DOUBLE_NEGATIVE_INF_FUNCTION =
"double_negative_inf";
- public static final String DOUBLE_NAN_FUNCTION = "double_nan";
- private static final Map<String, String> DOUBLE_FUNCTIONS =
+ public static final String DOUBLE_POSITIVE_INF_WRAPPER =
"double_positive_inf";
Review comment:
I agree. I will let this change get in and avoid similar changes in the
future. Sorry for the inconvenience.
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
##########
@@ -475,17 +512,22 @@
// FunctionSignatureId.FN_RANGE_BUCKET, // range_bucket(T,
array<T>) -> int64
- // FunctionSignatureId.FN_RAND, // rand() -> double
+ FunctionSignatureId.FN_RAND // rand() -> double
Review comment:
Thanks for catching this! I will disable this for now, and enable it
later once we have a thorough test.
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SupportedZetaSqlBuiltinFunctions.java
##########
@@ -277,29 +293,31 @@
FunctionSignatureId.FN_PARSE_DATETIME, // parse_datetime
FunctionSignatureId.FN_PARSE_TIME, // parse_time
FunctionSignatureId.FN_PARSE_TIMESTAMP, // parse_timestamp
+ // FunctionSignatureId.FN_LAST_DAY_DATE, // last_day date
+ // FunctionSignatureId.FN_LAST_DAY_DATETIME, // last_day datetime
// Math functions
- // FunctionSignatureId.FN_ABS_INT64, // abs
- // FunctionSignatureId.FN_ABS_DOUBLE, // abs
- // FunctionSignatureId.FN_ABS_NUMERIC, // abs
+ FunctionSignatureId.FN_ABS_INT64, // abs
Review comment:
Make sense. I will remember to separate different categories of changes
in the future. Thanks for the suggestion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
