amaliujia commented on a change in pull request #13200:
URL: https://github.com/apache/beam/pull/13200#discussion_r512942433
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRuleSets.java
##########
@@ -82,8 +80,6 @@
// Rules for window functions
ProjectToWindowRule.PROJECT,
// Rules so we only have to implement Calc
- FilterCalcMergeRule.INSTANCE,
- ProjectCalcMergeRule.INSTANCE,
Review comment:
Meanwhile, one rule is required for ZetaSQL planner is, we probably need
a `BeamZetaSQLCalcMergeRule`, which does not merge Calc when one Calc has Java
UDF but another Calc does not. This will be useful when users write query like
```
select java_udf(x) from (select builtin_function(y) as x from table) as t;
Thus we can have a plan as
JavaUDFRel
----ZetaSQLRel
--------TableScan
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
