yifanmai commented on a change in pull request #13048:
URL: https://github.com/apache/beam/pull/13048#discussion_r514452511
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -877,17 +877,19 @@ class CombineFn(WithTypeHints, HasDisplayData,
urns.RunnerApiFn):
combining process proceeds as follows:
1. Input values are partitioned into one or more batches.
- 2. For each batch, the create_accumulator method is invoked to create a fresh
+ 2. For each batch, the setup method is invoked.
+ 3. For each batch, the create_accumulator method is invoked to create a fresh
initial "accumulator" value representing the combination of zero values.
- 3. For each input value in the batch, the add_input method is invoked to
+ 4. For each input value in the batch, the add_input method is invoked to
combine more values with the accumulator for that batch.
- 4. The merge_accumulators method is invoked to combine accumulators from
+ 5. The merge_accumulators method is invoked to combine accumulators from
separate batches into a single combined output accumulator value, once all
of the accumulators have had all the input value in their batches added to
them. This operation is invoked repeatedly, until there is only one
accumulator value left.
- 5. The extract_output operation is invoked on the final accumulator to get
+ 6. The extract_output operation is invoked on the final accumulator to get
the output value.
+ 7. The teardown method is invoked.
Review comment:
SGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
