sonam-vend commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r516544404
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -95,7 +90,7 @@ class BeamModulePlugin implements Plugin<Project> {
boolean ignoreRawtypeErrors = false
/** Controls whether the dependency analysis plugin is enabled. */
- boolean enableStrictDependencies = false
+ boolean enableStrictDependencies = true
Review comment:
enabled dependency check via wfhartford plugin
##########
File path: examples/java/build.gradle
##########
@@ -67,7 +67,11 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile "com.google.code.findbugs:jsr305:3.0.2"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ permitUnusedDeclared "com.google.auto.value:auto-value-annotations:1.7.2"
+ permitUnusedDeclared "org.checkerframework:checker-qual:3.7.0"
Review comment:
Adding dependencies to permitUnusedDeclared or permitTestUnusedDeclared
causes the dependency analyzer to ignore cases where the dependencies are
declared but not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
