piotr-szuberski commented on a change in pull request #13230:
URL: https://github.com/apache/beam/pull/13230#discussion_r516589684
##########
File path: sdks/java/io/hadoop-format/build.gradle
##########
@@ -140,4 +157,12 @@ task hadoopFormatIOElasticTest(type: Test) {
testClassesDirs = sourceSets.test.output.classesDirs
include '**/HadoopFormatIOElasticIT.class'
useJUnit { }
-}
\ No newline at end of file
+}
+
+task hadoopVersion285Test(type: Test) {
+ dependsOn createTargetDirectoryForCassandra
+ description = "Runs Hadoop format tests with Hadoop version
$hadoop_285_version"
+ outputs.upToDateWhen { false }
+ include '**/*Test.class'
+ include '**/HadoopFormatIOElasticIT.class'
Review comment:
Oh right, it makes no sense to run `HadoopFormatIOElasticIT` here. This
test has a default configuration that can be run without setting up anything
but it indeed is inconsistent with the whole idea of `hadoopVersion285Test`
##########
File path: sdks/java/io/hadoop-format/build.gradle
##########
@@ -140,4 +157,12 @@ task hadoopFormatIOElasticTest(type: Test) {
testClassesDirs = sourceSets.test.output.classesDirs
include '**/HadoopFormatIOElasticIT.class'
useJUnit { }
-}
\ No newline at end of file
+}
+
+task hadoopVersion285Test(type: Test) {
+ dependsOn createTargetDirectoryForCassandra
+ description = "Runs Hadoop format tests with Hadoop version
$hadoop_285_version"
+ outputs.upToDateWhen { false }
+ include '**/*Test.class'
+ include '**/HadoopFormatIOElasticIT.class'
Review comment:
Cassandra is set for `HadoopFormatIOCassandraTest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
