kennknowles commented on a change in pull request #13221:
URL: https://github.com/apache/beam/pull/13221#discussion_r516896813
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/AfterWatermarkStateMachine.java
##########
@@ -91,6 +91,13 @@ public AfterWatermarkEarlyAndLate
withLateFirings(TriggerStateMachine lateTrigge
return new AfterWatermarkEarlyAndLate(earlyTrigger, lateTrigger);
}
+ @Override
+ public void prefetchOnElement(PrefetchContext c) {
+ for (ExecutableTriggerStateMachine subTrigger :
c.trigger().subTriggers()) {
Review comment:
This was the other one. Same problem with my thinking.
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/AfterEachStateMachine.java
##########
@@ -48,6 +48,13 @@ private AfterEachStateMachine(List<TriggerStateMachine>
subTriggers) {
checkArgument(subTriggers.size() > 1);
}
+ @Override
+ public void prefetchOnElement(PrefetchContext c) {
+ for (ExecutableTriggerStateMachine subTrigger : c.trigger().subTriggers())
{
Review comment:
This was one of the cases where I was thinking it only made sense to
prefetch the active subtrigger. Of course, I was missing the whole point that
you can't know which one that is until you do a fetch. So maybe my whole idea
was foolish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
