chamikaramj commented on a change in pull request #13234:
URL: https://github.com/apache/beam/pull/13234#discussion_r516950301
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
##########
@@ -584,6 +583,16 @@ public void testTriggeredFileLoadsWithTempTables() throws
Exception {
containsInAnyOrder(Iterables.toArray(elements, TableRow.class)));
}
+ @Test
+ public void testTriggeredFileLoadsWithTempTables() throws Exception {
+ testTriggeredFileLoadsWithTempTables("project-id:dataset-id.table-id");
+ }
+
+ @Test
+ public void testTriggeredFileLoadsWithTempTablesPartialTableRef() throws
Exception {
Review comment:
testTriggeredFileLoadsWithTempTablesDefaultProject ?
(what we'll be doing is picking the default project which is correct
according to the spec:
https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java#L395
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
