tvalentyn commented on a change in pull request #13048:
URL: https://github.com/apache/beam/pull/13048#discussion_r517731074
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -700,6 +700,9 @@ def __init__(self, n):
# helper instead.
self._top_combiner = TopCombineFn(n)
+ def setup(self):
+ self._top_combiner.setup()
Review comment:
I think this would fail the Dataflow V1 check as well.
I thought of possible improvement of the check [`bad0a52`
(#13267)](https://github.com/apache/beam/pull/13267/commits/bad0a522ced25cc6ceef3ad14563ed2f6419788f)
and this call would cause an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
