dmvk commented on pull request #13240: URL: https://github.com/apache/beam/pull/13240#issuecomment-722354299
> introduce usingImmutableTypes (or similar), which would have the meaning of both objectReuse and fasterCopy I think you got me wrong, what I'm trying to suggest is that there is basically no chance `objectReuse` can affect user code. Only think it affects in existing pipelines is runner code, which we have full control of. So it makes sense get rid of this flag completely as there is absolutely no benefit of exposing it to the user. Hiding it behind another knob is even worse than current state as it would be hard to understand what it actually does. > Is this with and without my change enabled? If yes, would you mind sending me an email with the setup and the two pipelines? It would be very useful data for my thesis! It's without your change. Just to note, this patch should have no effect on distribution of used Serializers as it only affects internal behavior of CoderTypeSerializer. We can do some basic profiling with & without your patch within next few weeks. I'll let you know once we have results ;) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
